Re: Upload Progress Meter Patch

Hello Tom, can you please provide a unified diff (diff -u) which everyone here understands? Also it would help to see a diff against HEAD. regards marcus Saturday, November 6, 2004, 1:16:33 AM, you wrote: > Hi, > Friday, November 5, 2004, 8:42:49 PM, you wrote: KR>> Marcus Boerger wrote: >>> Thinking about it another time you're right. So what the patch offers is >>> all we can do. However having the session id available somehow would make >>> the the patch usefull. KR>> I have some ideas for this. It may even be possible to remove the KR>> UPLOAD_IDENTIFIER-stuff from the patch and move it to the PHP extension. KR>> This would make the patch more independant. The author of the PHP KR>> extension can decide how this variable is named and how it is transmitted. KR>> If nobody has already a working solution I can give it a try this weekend. KR>> But one question stays: Let's say that the PHP extension now knows the KR>> PHP session ID during progress tracking (because it was passed like the KR>> UPLOAD_IDENTIFIER via a POST variable BEFORE the uploaded files). What KR>> can the extension do with it? Is it possible for this PHP extension to KR>> open the session, update variables in it, and close it again? Or is the KR>> stage in which the callback is called to early for doing so? > here are some changes I made to make a thread safe file upload. The diffs are > against 4.3.8 but should be close enough. I am not an expert by any means but it > may help -- Best regards, Marcus mailto:helly@php.net