Re[2]: [PHP-DEV] Upload Progress Meter Patch
| From: | Andi Gutmans | Date: | Sat, 06 Nov 2004 08:09:24 +0000 |
| Subject: | Re[2]: [PHP-DEV] Upload Progress Meter Patch | ||
| References: | 1 2 3 4 5 6 7 8 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-13754@lists.php.net to get a copy of this message | ||
Without commenting on the main part of the patch (I still haven't come to a conlusion either way), I don't see why you had to make any changes to the Zend Engine. Shouldn't those globals be declared outside the engine? (i.e. php5/main?).
Andi
At 01:55 PM 11/6/2004 +1000, Tom Rogers wrote:
Hi, Saturday, November 6, 2004, 10:25:57 AM, you wrote: MB> Hello Tom, MB> can you please provide a unified diff (diff -u) which everyone here MB> understands? Also it would help to see a diff against HEAD. MB> regards MB> marcus This is against the latest cvs 4.3 -- regards, Tom -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php