Re: Fix for php4 bug #30096
| From: | Derick Rethans | Date: | Mon, 15 Nov 2004 17:37:06 +0000 |
| Subject: | Re: Fix for php4 bug #30096 | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-13868@lists.php.net to get a copy of this message | ||
On Mon, 15 Nov 2004, Vladimir Zidar wrote:
> But then whole function php_mktime() is wrong, as in case where gm=1,
> you expect that parameters you pass are GMT, and still you fill defaults
> with localtime. Also, later, if gm=1, timezone adjustment is in use, but
> with parameters that are in GMT.
>
> So the real good fix would be to remove timezone stuff completly out of
> there, and make another function in pair with php_localtime_r, that
> returns GMT, and to use it when gm=1.
Sure, that's why I'm rewriting this stuff for PHP 5 ;-)
regards,
Derick
--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org