Re: Fix for php4 bug #30096
| From: | Vladimir Zidar | Date: | Mon, 15 Nov 2004 17:46:17 +0000 |
| Subject: | Re: Fix for php4 bug #30096 | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-13869@lists.php.net to get a copy of this message | ||
On Mon, 2004-11-15 at 18:37, Derick Rethans wrote:
> On Mon, 15 Nov 2004, Vladimir Zidar wrote:
>
> > But then whole function php_mktime() is wrong, as in case where gm=1,
> > you expect that parameters you pass are GMT, and still you fill defaults
> > with localtime. Also, later, if gm=1, timezone adjustment is in use, but
> > with parameters that are in GMT.
> >
> > So the real good fix would be to remove timezone stuff completly out of
> > there, and make another function in pair with php_localtime_r, that
> > returns GMT, and to use it when gm=1.
>
> Sure, that's why I'm rewriting this stuff for PHP 5 ;-)
I can see now that there is php_gmtime_r() function also. Can we use this when gm=1, and forget
about timezone there ?
I'll check now.