Re: [PATCH] ext/xml/compat.c fix for #32001
| From: | Joe Orton | Date: | Thu, 17 Feb 2005 13:28:38 +0000 |
| Subject: | Re: [PATCH] ext/xml/compat.c fix for #32001 | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-15047@lists.php.net to get a copy of this message | ||
On Thu, Feb 17, 2005 at 07:19:46AM -0500, Rob Richards wrote:
> It looks like there would be BC breaks unless libxml with the bug fix is
> used as the encoding is detected properly and no infinite loop if an xml
> declaration or BOM is used in the xml. So basically with the patch there
> is no more autodetecting if used with any other libxml versions (though
> no more possibilities of inifinte loops).
That's not quite right: detection based on an ASCII <?xml prolog with an
explicit encoding= still works fine with the patch applied (e.g. for
encoding=ISO-8859-1 documents). It's *only* documents which have a BOM
which will then fail to parse.
So it is a bit of a tricky trade-off...