Re: [PATCH] ext/xml/compat.c fix for #32001
| From: | Rob Richards | Date: | Thu, 24 Feb 2005 20:49:13 +0000 |
| Subject: | Re: [PATCH] ext/xml/compat.c fix for #32001 | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-15183@lists.php.net to get a copy of this message | ||
What about this patch? Really hacky as the charset is checked before the
inital parse and it basically duplicates the libxml code with the
correct fix, but seems to work ok. Havent tried it with any large
datasets yet which require multiple parse calls, but it should work.
Rob
Joe Orton wrote:
>
>That's not quite right: detection based on an ASCII <?xml prolog with an
>explicit encoding= still works fine with the patch applied (e.g. for
>encoding=ISO-8859-1 documents). It's *only* documents which have a BOM
>which will then fail to parse.
>
>So it is a bit of a tricky trade-off...
>
>
>