Re: HALT Patch
| From: | Sara Golemon | Date: | Fri, 11 Mar 2005 22:11:41 +0000 |
| Subject: | Re: HALT Patch | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-15386@lists.php.net to get a copy of this message | ||
> 1) while (fgets($fp) != '<?php __HALT_PHP_PARSER__; ?>'));
>
Just a nudge about this code approach.
#1 It doesn't detect EOF
#2 It forgets about the newline returned by fgets()
#3 It doesn't allow the HALT; to float within a line between other content
(not that you'd do that anyway but...
while (($tmp = fgets($fp)) && (strpos($tmp, '<?php __HALT_PHP_PARSER__; ?>')
!== false));