Re: HALT Patch
| From: | Ilia Alshanetsky | Date: | Fri, 11 Mar 2005 22:30:30 +0000 |
| Subject: | Re: HALT Patch | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-15389@lists.php.net to get a copy of this message | ||
Sara Golemon wrote:
Just a nudge about this code approach. #1 It doesn't detect EOFWell, if you encounter EOF before the HALT tag, it means as a developer of the script you are trying to break your own code ;-)
#2 It forgets about the newline returned by fgets(True, I suppose strncmp could be used here, since newline is not always constant.
#3 It doesn't allow the HALT; to float within a line between other content (not that you'd do that anyway but...Going back to #1 ;-). Ilia