Re: Two minor issues in 5.0.4
| From: | Antony Dovgal | Date: | Sun, 27 Mar 2005 11:55:56 +0000 |
| Subject: | Re: Two minor issues in 5.0.4 | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-15634@lists.php.net to get a copy of this message | ||
On Sat, 26 Mar 2005 13:05:56 +0300
Antony Dovgal <antony@zend.com> wrote:
> Hi all!
>
> I'd like to fix two minor issues before releasing 5.0.4.
>
> These issues are:
> 1) mmap'ed files are bound to 2M.
> In HEAD PHP_STREAM_COPY_ALL is ((size_t)-1), but for some reasons in 5.0.4 it is set to
> 2000000.
> That causes readfile() to read only 2Mb and stop (which is rather frustrating).
> See main/php_streams.h
>
> 2) output_reset_rewrite_vars() *always* returns false.
> See php_url_scanner_reset_var() in ext/standard/url_scanner_ex.re,
> IMO it's just a silly typo, but this routine returns FAILURE in any case.
> The very same problem actually exists in all other branches too
>
> If nobody objects, I'll fix both issues in the evening.
Ilia, Zeev, any objections?
--
Wbr,
Antony Dovgal aka tony2001
antony@zend.com