Re: Two minor issues in 5.0.4
| From: | Antony Dovgal | Date: | Sun, 27 Mar 2005 12:57:36 +0000 |
| Subject: | Re: Two minor issues in 5.0.4 | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-15636@lists.php.net to get a copy of this message | ||
On Sun, 27 Mar 2005 14:51:09 +0200
Zeev Suraski <zeev@zend.com> wrote:
> How are you planning to change it?
See the diffs attached.
--
Wbr,
Antony Dovgal aka tony2001
antony@zend.com
Index: main/php_streams.h =================================================================== RCS file: /repository/php-src/main/php_streams.h,v retrieving revision 1.95.2.2 diff -u -p -d -r1.95.2.2 php_streams.h --- main/php_streams.h 22 Feb 2005 00:24:50 -0000 1.95.2.2 +++ main/php_streams.h 27 Mar 2005 12:55:37 -0000 @@ -413,7 +413,7 @@ END_EXTERN_C() * Uses mmap if the src is a plain file and at offset 0 * To ensure we don't take up too much memory when reading large files, set the default mmap length * at this many bytes */ -#define PHP_STREAM_COPY_ALL 2000000 +#define PHP_STREAM_COPY_ALL ((size_t)-1) BEGIN_EXTERN_C() PHPAPI size_t _php_stream_copy_to_stream(php_stream *src, php_stream *dest, size_t maxlen STREAMS_DC TSRMLS_DC); Index: ext/standard/url_scanner_ex.re =================================================================== RCS file: /repository/php-src/ext/standard/url_scanner_ex.re,v retrieving revision 1.72.2.1 diff -u -p -d -r1.72.2.1 url_scanner_ex.re --- ext/standard/url_scanner_ex.re 23 Jul 2004 02:05:51 -0000 1.72.2.1 +++ ext/standard/url_scanner_ex.re 27 Mar 2005 12:55:56 -0000 @@ -488,7 +488,7 @@ int php_url_scanner_reset_vars(TSRMLS_D) BG(url_adapt_state_ex).form_app.len = 0; BG(url_adapt_state_ex).url_app.len = 0; - return FAILURE; + return SUCCESS; } PHP_MINIT_FUNCTION(url_scanner) Index: ext/standard/url_scanner_ex.c =================================================================== RCS file: /repository/php-src/ext/standard/url_scanner_ex.c,v retrieving revision 1.86.2.1 diff -u -p -d -r1.86.2.1 url_scanner_ex.c --- ext/standard/url_scanner_ex.c 23 Jul 2004 02:05:51 -0000 1.86.2.1 +++ ext/standard/url_scanner_ex.c 27 Mar 2005 12:55:56 -0000 @@ -1059,7 +1059,7 @@ int php_url_scanner_reset_vars(TSRMLS_D) BG(url_adapt_state_ex).form_app.len = 0; BG(url_adapt_state_ex).url_app.len = 0; - return FAILURE; + return SUCCESS; } PHP_MINIT_FUNCTION(url_scanner)
Index: main/php_streams.h =================================================================== RCS file: /repository/php-src/main/php_streams.h,v retrieving revision 1.95.2.2 diff -u -p -d -r1.95.2.2 php_streams.h --- main/php_streams.h 22 Feb 2005 00:24:50 -0000 1.95.2.2 +++ main/php_streams.h 27 Mar 2005 12:55:37 -0000 @@ -413,7 +413,7 @@ END_EXTERN_C() * Uses mmap if the src is a plain file and at offset 0 * To ensure we don't take up too much memory when reading large files, set the default mmap length * at this many bytes */ -#define PHP_STREAM_COPY_ALL 2000000 +#define PHP_STREAM_COPY_ALL ((size_t)-1) BEGIN_EXTERN_C() PHPAPI size_t _php_stream_copy_to_stream(php_stream *src, php_stream *dest, size_t maxlen STREAMS_DC TSRMLS_DC); Index: ext/standard/url_scanner_ex.re =================================================================== RCS file: /repository/php-src/ext/standard/url_scanner_ex.re,v retrieving revision 1.72.2.1 diff -u -p -d -r1.72.2.1 url_scanner_ex.re --- ext/standard/url_scanner_ex.re 23 Jul 2004 02:05:51 -0000 1.72.2.1 +++ ext/standard/url_scanner_ex.re 27 Mar 2005 12:55:56 -0000 @@ -488,7 +488,7 @@ int php_url_scanner_reset_vars(TSRMLS_D) BG(url_adapt_state_ex).form_app.len = 0; BG(url_adapt_state_ex).url_app.len = 0; - return FAILURE; + return SUCCESS; } PHP_MINIT_FUNCTION(url_scanner) Index: ext/standard/url_scanner_ex.c =================================================================== RCS file: /repository/php-src/ext/standard/url_scanner_ex.c,v retrieving revision 1.86.2.1 diff -u -p -d -r1.86.2.1 url_scanner_ex.c --- ext/standard/url_scanner_ex.c 23 Jul 2004 02:05:51 -0000 1.86.2.1 +++ ext/standard/url_scanner_ex.c 27 Mar 2005 12:55:56 -0000 @@ -1059,7 +1059,7 @@ int php_url_scanner_reset_vars(TSRMLS_D) BG(url_adapt_state_ex).form_app.len = 0; BG(url_adapt_state_ex).url_app.len = 0; - return FAILURE; + return SUCCESS; } PHP_MINIT_FUNCTION(url_scanner)