Re: PECL Package Proposal: kadm5 - REPOST
| From: | Sander Roobol | Date: | Fri, 16 May 2003 13:34:08 +0000 |
| Subject: | Re: PECL Package Proposal: kadm5 - REPOST | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-1566@lists.php.net to get a copy of this message | ||
On Fri, May 16, 2003 at 03:25:04PM +0200, Holger Burbach wrote:
> There is a new release of kadm5 with some minor changes. The sources can
> be found at:
>
> ftp://oss.gonicus.de/pub/php-kadm5/php-kadm5-0.2.2/
Looks fine, BUT (Derick, still reading? :)
* There are some comments from the ext/skel that should (IMO) be
removed. Stuff like 'If you have INI entries ...'
* The PHP_FUNCTION()s don't have protos. Please add them.
* There are some whitespace inconsistancies here and there.
Apart from that +1.
Sander