Re: PECL Package Proposal: kadm5 - REPOST

Hey Holger, On Fri, 16 May 2003, Holger Burbach wrote: > > 1. The biggest problem I see is that the extension is throwing E_ERRORs > > which extensions really should not do if they do not leave *PHP* in > > an unstable state (there is also no \n required at the end of the text, > > and in the best case php_error_docref should be used). > > So throwing E_WARNING would be better? Definitely. (After an E_WARNING just return FALSE (or NULL)). > > 2. Check our CODING STANDARDS file again :) > > Okay, I'm working on that. > > > 3. I would recommend to use this naming (As example): > > kadm5_principal_create > > kadm5_principal_modify > > > > instead of: > > kadm5_create_principal > > kadm5_modify_principal > > Sounds reasonable. > > > 4. There are no prototypes for the PHP_FUNCTIONs > > Okay, I'm working on that. > > > 5. There should be atleast one test per function, if possible. > > Hmm, to test the functions I have to connect to an Kerberos V administration > server... Yeah, I know :) But tests also can work as examples so there is something to gain there. The DBX (ext/dbx) guys figured out something clever to handle cases where the DB server was not available, perhaps you can have a look on how they did it. good luck, Derick -- "my other box is your windows PC" ------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ International PHP Magazine http://php-mag.net/ -------------------------------------------------------------------------