Re: Re: cvs: php-src /ext/standard md5.c sha1.c
| From: | Uwe Schindler | Date: | Fri, 15 Apr 2005 15:15:24 +0000 |
| Subject: | Re: Re: cvs: php-src /ext/standard md5.c sha1.c | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-15969@lists.php.net to get a copy of this message | ||
I can remove this parameter. Without it, the function declaration keeps constant and we could add this patch to PHP_5_0, too. It does not change the user interface but makes C code simplier and adds support for URLs without any cost to it.
The original intention to change the md5/sha1 code was to remove stdio and convert to posix io (as done in 4.3 and 5.0) because of the solaris stdio problems. But php_streams is even better.
Uwe
At 17:08 15.04.2005, you wrote:
Uwe Schindler wrote:----- Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de - http://www.schindlers-software.de eMails: uwe@thetaphi.de (private); info@schindlers-software.de (company) Tel./Fax: +49 700 PCLATEIN (+49 700 72528346) Schindlers Software - Home of Schindlers PC-LATEIN 3.10 DIE Software zum Lateinlernen!We can left that out. The flag to search in the include path is available to all file_* functions in PHP. Make it sense to search in the include path for example in the exif-functions? But this parameter is available there, too. So for consistency I added this parameter. At 16:37 15.04.2005, you wrote:Then file_exists() is also incosistent :). Do add additional param to it too. Andrey