Re: Re: cvs: php-src /ext/standard md5.c sha1.c

From: Date: Fri, 15 Apr 2005 16:51:38 +0000
Subject: Re: Re: cvs: php-src /ext/standard md5.c sha1.c
References: 1 2 3 4 5  Groups: php.internals 
Request: Send a blank email to internals+get-15973@lists.php.net to get a copy of this message
> > > We can left that out. The flag to search in the include path is available to > > > all file_* functions in PHP. Make it sense to search in the include path for > > > example in the exif-functions? But this parameter is available there, too. > > > So for consistency I added this parameter. > > > Except that it's not. Most, in fact, do not include it. It's just the high visibility ones {fopen(), file(), file_get_contents()} that you see it on. > > Then file_exists() is also incosistent :). Do add additional param to it too. > No! Do not do that - that will definitely going to break BC. > Rather than getting prototype change happy. How about a context parameter for the file:// wrapper since it only applies to plainfiles anyway. (Note: Okay so it applies to plainfile wrappers like compress.gzip:// but that just opens the subordinate resource as a wrapper and winds up at file:// anyway) Keep the flag on functions like fopen() for BC purposes, but don't add it anywhere else, there's no need for it. -Sara

« previous php.internals (#15973) next »