Re: Re: References Problem Patch
| From: | Derick Rethans | Date: | Mon, 30 May 2005 14:14:43 +0000 |
| Subject: | Re: Re: References Problem Patch | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-16318@lists.php.net to get a copy of this message | ||
On Mon, 30 May 2005, Christian Schneider wrote:
> Zeev Suraski wrote:
> > If it was an issue that everyone and their dog was bumping into, then I may
> > have thought differently - but it's an issue that is rare enough, and can be
> > worked around. And those that really need it to be fixed - can use the
> > patch.
>
> As we have run into segfaults with objects and references a couple of times
> here I'd be interested in more details about the problem and the implications
> of the patch.
See my two testcases:
http://files.derickrethans.nl/patches/reference-bug.phps
http://files.derickrethans.nl/patches/reference-test-case2.phps
But you would only spot it with valgrind and turning off Zend's memory
manager. The MM hides this kinds of errors pretty well.
> I'm reading the mailing list throught the NNTP interface and it seems to miss
> part of the conversation as the thread starts with Re: References Problem
> Patch. Seems to be the same for the mailing list archive.
It was a private discussion between Dmitry and me about the technical
aspects of the patch.
> If you decide not to fix the 4.x branch then we'd minimally need an easily
> accessible document describing the known problems and work-arounds IMHO.
As I tried to do that in our large code base, I would say that's totally
not possible to do. There is no way you know you're doing someting
wrong, as there are no warnings and go through 200k+ lines of code
without missing an instance is impossible.
regards,
Derick
--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org