Re: Re: HANDLE_NUMERIC()

On Thursday, May 22, 2003, at 02:58 PM, Andi Gutmans wrote:

At 12:52 PM 5/22/2003 -0400, Sterling Hughes wrote:

Hi, I've attached a small patch which removes HANDLE_NUMERIC() from zend_hash.c, and moves it instead to the necessary places in zend_execute.c, in the form of a zend_is_numeric_key() function defined in zend_operators.c Anyhow, I'm getting a really nice performance increase. Although it depends on the usage, it certainly makes pretty much everything zippier (and dare I say sexier. :)

I'm not sure you can be certain that other places in PHP don't use the feature of HANDLE_NUMERIC. Seems to be quite a dangerous patch to me even if you solved it for the symbol table.

Yeah... seems safer using your leaner symbol tables where appropriate rather than carving up the current implementation. George