Re: Re: HANDLE_NUMERIC()

Sterling, I discussed your patch with Zeev. He convinced me that the chance of other PHP extensions taking advantage of HANDLE_NUMERIC is slim and that if this exists, we'll find it by the time we release PHP 5. So I think you should commit it. Andi At 09:58 PM 5/22/2003 +0300, Andi Gutmans wrote:

At 12:52 PM 5/22/2003 -0400, Sterling Hughes wrote:

Hi, I've attached a small patch which removes HANDLE_NUMERIC() from zend_hash.c, and moves it instead to the necessary places in zend_execute.c, in the form of a zend_is_numeric_key() function defined in zend_operators.c Anyhow, I'm getting a really nice performance increase. Although it depends on the usage, it certainly makes pretty much everything zippier (and dare I say sexier. :)

I'm not sure you can be certain that other places in PHP don't use the feature of HANDLE_NUMERIC. Seems to be quite a dangerous patch to me even if you solved it for the symbol table. Andi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php