It's ridiculous for an extension in PHP_5_1 branch
to "have to" work for, say, PHP 4.4.
Haven't you heard about these incredible things they
developed in CVS called "branches" ?
--Jani
On Sat, 24 Sep 2005, Wez Furlong wrote:
Jani, damnit, stop trying so hard to make things difficult.
If you read the bug reports, they were both with PHP 5.0.3.
Since we're using PHP 5.1 as the source for both PHP 5.1 and PECL,
this absolutely MUST also work on PHP 5.0.x.
Either restore the fix or do something to make PHP 5.0.x happy.
If you keep this obstruction up, I'm going to remove your karma from PDO.
--Wez.
On 9/24/05, Jani Taskinen <sniper@php.net> wrote:
sniper Sat Sep 24 19:33:58 2005 EDT
Modified files: (Branch: PHP_5_1)
/php-src/ext/pdo_sqlite config.m4
Log:
Revert the "fix". It works fine when you use PHP_5_1
http://cvs.php.net/diff.php/php-src/ext/pdo_sqlite/config.m4?r1=1.26.2.3&r2=1.26.2.4&ty=u
Index: php-src/ext/pdo_sqlite/config.m4
diff -u php-src/ext/pdo_sqlite/config.m4:1.26.2.3 php-src/ext/pdo_sqlite/config.m4:1.26.2.4
--- php-src/ext/pdo_sqlite/config.m4:1.26.2.3 Sat Sep 24 19:23:25 2005
+++ php-src/ext/pdo_sqlite/config.m4 Sat Sep 24 19:33:58 2005
@@ -1,4 +1,4 @@
-dnl $Id: config.m4,v 1.26.2.3 2005/09/24 23:23:25 sniper Exp $
+dnl $Id: config.m4,v 1.26.2.4 2005/09/24 23:33:58 sniper Exp $
dnl config.m4 for extension pdo_sqlite
dnl vim:et:sw=2:ts=2:
@@ -83,7 +83,7 @@
PHP_NEW_EXTENSION(pdo_sqlite,
$php_pdo_sqlite_sources_core $pdo_sqlite_sources,
- $ext_shared,,-I$ext_builddir/sqlite/src -DPDO_SQLITE_BUNDLED=1 -DSQLITE_OMIT_CURSOR -I$pdo_inc_path)
+ $ext_shared,,-I@ext_builddir@/sqlite/src -DPDO_SQLITE_BUNDLED=1 -DSQLITE_OMIT_CURSOR -I$pdo_inc_path)
PHP_ADD_BUILD_DIR($ext_builddir/sqlite/src, 1)
AC_CHECK_SIZEOF(char *,4)
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
--
Donate @ <http://pecl.php.net/wishlist.php/sniper>
Disclaimer: Donating money may make me happier and friendlier for a limited period!