Re: Re: cvs: php-src / Makefile.gcov NEWS configure.ingen_php_cov

Hello Nuno, we might want to increase re2c version requirement and have re2c omit those lines for gcov builds (re2c -i). marcus Thursday, October 20, 2005, 9:29:24 PM, you wrote: >> You can get rid of the "bogus" #line lines with using >> the genfiles script. Don't even dream about getting rid >> of them in the files by using the -L or -l options for flex/bison!! >> >> --Jani > No, of corse not :) I've used that just for testing. > I was mainly refering to the re2c files, which most have absolute paths (and > not everyone downloads the sources to the same dir :) ), and some have > <stdout>. > Nuno >> On Thu, 20 Oct 2005, Nuno Lopes wrote: >> >>> >>>> john Wed Oct 19 20:18:26 2005 EDT >>>> >>>> Added files: >>>> /php-src Makefile.gcov gen_php_cov >>>> >>>> Modified files: >>>> /php-src NEWS configure.in >>>> Log: >>>> Implementing C-level Code coverage (--enable-gcov). >>>> >>>> o Requires LTP 1.4+ and libgcov >>> >>> Hello, >>> >>> As I've told you before, I had already tested your patch. It has the >>> problem in the parsers that have bogus #line directives (but thats >>> another story). The other problem is that you don't handle files with the >>> same name. >>> >>> BTW, I have asked a server from my university for PHP automated testing. >>> They told me that they would give me one, but I haven't received the code >>> yet (waiting..). >>> I have already done a little cron job to automates the things. The >>> strongest point in the little programs I've developed is a patch for >>> run-tests.php to let them run with valgrind, to check for mem leaks in >>> each test. It is slow, but works very well. This particular patch I would >>> like to see in CVS (see the phpt_diff_w.txt file in my public cvs) >>> >>> the stuff is at: >>> http://mega.ist.utl.pt/~ncpl/cvs/viewcvs.cgi/phpqa/ >>> >>> >>> Nuno Best regards, Marcus