Don't even think about merging that mess into PHP_5_1 before
I've got it sorted out!
And next time you want to mess around configure/makefiles
ask me before you commit!
--Jani
On Sat, 22 Oct 2005, John Coggeshall wrote:
On Thu, 2005-10-20 at 20:20 +0100, Nuno Lopes wrote:
As I've told you before, I had already tested your patch. It has the problem
in the parsers that have bogus #line directives (but thats another story).
The other problem is that you don't handle files with the same name.
Yeah I'm aware of the #line directives. I just needed to get the code
into CVS -- since HEAD's test suite is pretty borked anyway from what
Andrei tells me I figured I'd address these two issues afterwards. I'm
also going to back port this patch to PHP 5.1.1 after 5.1.0 is released
at ilia's request so we can actually start using it.
BTW, I have asked a server from my university for PHP automated testing.
They told me that they would give me one, but I haven't received the code
yet (waiting..).
Wez and I discussed setting this process up on master.php.net since it
is pretty idle most of the time.
I have already done a little cron job to automates the things. The strongest
point in the little programs I've developed is a patch for run-tests.php to
let them run with valgrind, to check for mem leaks in each test. It is slow,
but works very well. This particular patch I would like to see in CVS (see
the phpt_diff_w.txt file in my public cvs)
It looks sorta interesting, especially with the major Unicode changes we
are making -- I'll check it out too.
While I'm thinking about it, considering how much effort we may have to
put into making the test suite work again is it worthwhile to consider
taking a look at reimplementing the framework? Just a thought.
John
--
Give me your money at @ <http://pecl.php.net/wishlist.php/sniper>
Donating money may make me happier and friendlier for a limited period!
Death to all 4 letter abbreviations starting with P!