Re: Solution to date issue in 5.1
| From: | Lester Caine | Date: | Sat, 26 Nov 2005 11:05:56 +0000 |
| Subject: | Re: Solution to date issue in 5.1 | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-20515@lists.php.net to get a copy of this message | ||
Rasmus Lerdorf wrote:
Ilia Alshanetsky wrote:I strikes me that there is a more subtle problem here which goes beyond just renaming Date, since we have had a period where people ARE building their own libraries with their own classes. So while the current niggle is Date, any new core class can potentially cause a problem. Before we have any movement forward, a agreed method of ring fencing core classes has to be sorted out since this was not implemented previously? -- Lester Caine ----------------------------- L.S.Caine Electronic Services Treasurer - Firebird Foundation Inc.The attached patch is a possible solution to the date *crisis*, it renames the class to PhpDate to avoid any namespace conflicts with pear or custom user classes called date. If there are no strong objection 5.1.1 (5.1.0 + this patch and nothing else) goes out on Monday.I don't think choosing a precedent for a class naming convention should be done under duress like this. I say just ifdef it back out then and put those constants back as they were before. This class doesn't buy us anything. It's just a forward-looking thing that really shouldn't go in unless we can all agree on what it is we are looking forward at.