Re: FastCGI unix sockets support patch

Wouldn't you typically use a full (absolute) path to a unix socket? And, is it not so that hostnames should not contain /'s or <'s, etc? (I'm not sure what other path separators are used on platforms PHP supports, but I'm pretty sure they all use funky characters.) Assuming these cases are true, and handled, I don't think it's much of a flaw in the system, personally. -[Unknown] -------- Original Message --------

On Thu, 23 Mar 2006 13:23:40 +0300 dmitry@zend.com ("Dmitry Stogov") wrote:

Hi Rostisla, I've committed another patch into HEAD and PHP_5_1, that allows usage of UNIX sockets without ':'. -b <host>:<port_number> -b <port_number> -b <unix_path>

It means that a choice of the unix_path is restricted. It cannot be a number and cannot include ":number" at the end. I've seen the diff of sapi/cgi/cgi_main.c after your commit. IMHO the distinction between TCP/IP and UNIX socket better to be done according to last ":", as in proposed by me version of sapi/cgi/fastcgi.c. Alternative and maybe much better solution is to use different bind options for TCP/IP and UNIX sockets. For example -b and -B. Anyway sapi/cgi/fastcgi.c should be canged.