RE: [PHP-DEV] FastCGI unix sockets support patch

I don't think that "-b <path>:" is good solution. Two different options for TCP and UNIX sockets make sense. What is wrong with sapi/cgi/fastcgi.c? Thanks. Dmitry. > -----Original Message----- > From: Rostislav Krasny [mailto:rosti.bsd@gmail.com] > Sent: Thursday, March 23, 2006 8:18 PM > To: internals@lists.php.net; "Dmitry Stogov" > Subject: Re: [PHP-DEV] FastCGI unix sockets support patch > > > On Thu, 23 Mar 2006 13:23:40 +0300 > dmitry@zend.com ("Dmitry Stogov") wrote: > > > Hi Rostisla, > > > > I've committed another patch into HEAD and PHP_5_1, that > allows usage > > of UNIX sockets without ':'. > > > > -b <host>:<port_number> > > -b <port_number> > > -b <unix_path> > > It means that a choice of the unix_path is restricted. It > cannot be a number and cannot include ":number" at the end. > > I've seen the diff of sapi/cgi/cgi_main.c after your commit. > IMHO the distinction between TCP/IP and UNIX socket better to > be done according to last ":", as in proposed by me version > of sapi/cgi/fastcgi.c. Alternative and maybe much better > solution is to use different bind options for TCP/IP and UNIX > sockets. For example -b and -B. Anyway sapi/cgi/fastcgi.c > should be canged. > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > >