Re: tiny patch for Tidy

BTW, the libtidy could be updated :) It had a major optimization a few time ago (it decreased my bechmark running time by ~30%). Nuno ----- Original Message ----- From: "Steph Fox" <steph@zend.com> To: "internals" <internals@lists.php.net> Cc: "Edin" <edink@emini.dk> Sent: Wednesday, April 19, 2006 12:00 PM Subject: Re: [PHP-DEV] tiny patch for Tidy

Oops, forget it. The problem with having both PECL and src on board is I assumed I was building against the one with this change in it. I wasn't - I was building against the one that didn't have tidyOptGetDoc in the export list AT ALL. Just ran a test and found this is illegal syntax :( so back to the drawing board. (Edin: is there some way you know of to do an #ifdef equivalent in these export lists?) - Steph ----- Original Message ----- From: "Steph Fox" <steph@zend.com> To: "internals" <internals@lists.php.net> Sent: Wednesday, April 19, 2006 12:34 PM Subject: [PHP-DEV] tiny patch for Tidy

This allows static builds under win32 despite the fact that tidyOptGetDoc() doesn't exist in the libtidy.lib we're linking against. It needs applying to php_tidy.def everywhere libtidy v 2 is used - that is, ext/tidy in CVS HEAD and PHP_5_1, and CVS HEAD pecl/tidy. In all three cases there is the same #ifdef clause for the matching tidy_get_opt_doc() function in the header file. - Steph