Re: tiny patch for Tidy

From:	Steph Fox	Date:	Wed, 19 Apr 2006 11:42:34 +0000
Subject:	Re: tiny patch for Tidy
References:	1 2	Groups:	php.internals
Request:	Send a blank email to internals+get-22851@lists.php.net to get a copy of this message

OK. I've just found that that .defs file is _only_ used by the static win32 build. It doesn't affect anything else, on any other platform. That makes fixing it even easier :) one line instead of three, you just don't export the function that doesn't exist. If/when we ever get that function in libtidy.lib, the ext/tidy (or PECL/tidy) static build will complain that it's missing - but for now they throw a fatal error _anyway_. I do realize I'm the only person in the entire universe to build extensions statically under win32 in the first place, but since we apparently have this entire defs/exports system set up to allow precisely that - what about having it working too? :) - Steph

Oops, forget it. The problem with having both PECL and src on board is I assumed I was building against the one with this change in it. I wasn't - I was building against the one that didn't have tidyOptGetDoc in the export list AT ALL. Just ran a test and found this is illegal syntax :( so back to the drawing board. (Edin: is there some way you know of to do an #ifdef equivalent in these export lists?) - Steph ----- Original Message ----- From: "Steph Fox" <steph@zend.com> To: "internals" <internals@lists.php.net> Sent: Wednesday, April 19, 2006 12:34 PM Subject: [PHP-DEV] tiny patch for Tidy
This allows static builds under win32 despite the fact that tidyOptGetDoc() doesn't exist in the libtidy.lib we're linking against. It needs applying to php_tidy.def everywhere libtidy v 2 is used - that is, ext/tidy in CVS HEAD and PHP_5_1, and CVS HEAD pecl/tidy. In all three cases there is the same #ifdef clause for the matching tidy_get_opt_doc() function in the header file. - Steph __________ NOD32 1.1380 (20060125) Information __________ This message was checked by NOD32 antivirus system. http://www.eset.com
--------------------------------------------------------------------------------
-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php __________ NOD32 1.1380 (20060125) Information __________ This message was checked by NOD32 antivirus system. http://www.eset.com
-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php __________ NOD32 1.1380 (20060125) Information __________ This message was checked by NOD32 antivirus system. http://www.eset.com

Index: ext/tidy/php_tidy.def =================================================================== RCS file: /repository/php-src/ext/tidy/php_tidy.def,v retrieving revision 1.2 diff -u -r1.2 php_tidy.def --- ext/tidy/php_tidy.def 25 Apr 2005 20:46:16 -0000 1.2 +++ ext/tidy/php_tidy.def 19 Apr 2006 11:34:57 -0000 @@ -45,7 +45,6 @@ tidyOptGetDefault tidyOptGetDefaultInt tidyOptGetDefaultBool -tidyOptGetDoc tidyOptGetPickList tidyOptGetNextPick tidyOptGetValue