[PATCH] array_combine is not binary-key safe
| From: | Matt W | Date: | Fri, 21 Jul 2006 12:08:41 +0000 |
| Subject: | [PATCH] array_combine is not binary-key safe | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-24833@lists.php.net to get a copy of this message | ||
Hi,
I don't know if array_combine() was intentionally made binary-key unsafe,
but it seems wrong and inconsistent since binary keys work everywhere else I
can think of -- including array_flip() and the new array_fill_keys(). And
updating it is a bit of an optimization by eliminating strlen() calls. :-)
I also changed the error message to be more grammatically-correct and fixed
some typos in the description.
http://www.realplain.com/php/array_combine_binkey.diff
http://www.realplain.com/php/array_combine_binkey_5_2.diff
Thanks,
Matt