Re: [PATCH] array_combine is not binary-key safe
| From: | bertrand Gugger | Date: | Mon, 24 Jul 2006 06:02:21 +0000 |
| Subject: | Re: [PATCH] array_combine is not binary-key safe | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-24918@lists.php.net to get a copy of this message | ||
Matt W wrote:
Hi Andrei, I see you applied my patch. Testing with a php5.2-200607222030 snaps having/* $Id: array.c,v 1.308.2.21.2.7 2006/07/22 16:58:39 andrei Exp $ */ Looks by me as the ext/standard/tests/array/array_combine.phpt fails Is it by me ? $ diff -W 60 -y --suppress-common-lines ext/standard/tests/array/array_combine.exp ext/standard/tests/array/array_combine.out
[green] => green | [gree] => green
[red] => red | [re] => red
[yellow] => yellow | [yello] => yellow
[green] => 1 | [gree] => 1
[red] => 2 | [re] => 2
[yellow] => 3 | [yello] => 3
[green] => 0 | [gree] => 0
[red] => 1 | [re] => 1
[yellow] => 2 | [yello] => 2
[green] => 1 | [gree] => 1
[red] => | [re] =>
[yellow] => | [yello] =>
[1] => green | [] => green
[2] => red | [] => red
[3] => yellow | [] => yellow
[1] => 1 | [] => 1
[2] => 2 | [] => 2
[3] => 3 | [] => 3
[1] => 0 | [] => 0
[2] => 1 | [] => 1
[3] => 2 | [] => 2
[1] => 1 | [] => 1
[2] => | [] =>
[3] => | [] =>
PHP : /home/bertrand/php/php5.2-200607222030/sapi/cli/php PHP_SAPI : cliPHP_VERSION : 5.2.0-dev ZEND_VERSION: 2.2.0
PHP_OS : Linux - Linux ancilla.toggg.net 2.6.12-1.1381_FC3 #1 Fri Oct 21 03 :46:55 EDT 2005 i686Configure Command => './configure' Sorry for the noise , case I did something wrong , but what ? (or case it is repaired in the mean time) -- toggg