Re: [PATCH] number_format enhancements
| From: | bertrand Gugger | Date: | Sat, 22 Jul 2006 23:21:07 +0000 |
| Subject: | Re: [PATCH] number_format enhancements | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-24891@lists.php.net to get a copy of this message | ||
Matt W wrote:
> Hi,
>
> Haven't heard any opinions on these functionality changes... (Though I know
> more significant things keep you busy!)
>
> Do many other people use number_format()?? Wouldn't allowing thousands
> separator as param #2 simplify things?
>
> Any issues with the semantics of operation? Negative precision to specify
> trailing zero removal seems fine at least, even though that's different than
> round()'s behavior.
>
> I've now made some tests, including changes of course, in case you were just
> waiting for them? Hope they're enough.
>
> http://realplain.com/php/number_format.phpt
Sorry , I did not come better than the attached test
copies http://toggg.info/number_format.phpt &
http://toggg.info/number_format.diff
(you don't need "\n")
I wonder why lines are fliping , I guess it's a diff effect
Let me know how I apply your patch , so I get it blank :)
--
toggg