Re: [PATCH] number_format enhancements

Hi, ----- Original Message ----- From: "bertrand Gugger" Sent: Saturday, July 22, 2006 > Bonsoir Matt, > Matt W wrote: > > Hi, > > > > Haven't heard any opinions on these functionality changes... (Though I know > > more significant things keep you busy!) > > > > Do many other people use number_format()?? Wouldn't allowing thousands > > separator as param #2 simplify things? > > > > Any issues with the semantics of operation? Negative precision to specify > > trailing zero removal seems fine at least, even though that's different than > > round()'s behavior. > > > > I've now made some tests, including changes of course, in case you were just > > waiting for them? Hope they're enough. > > > > http://realplain.com/php/number_format.phpt > I did not look into that .phpt link > I belong only to userland , so have less to tell here. > > Give some basic userland examples about what you propose to change, > please ... > (I guess these are a part of the .phpt) > > Bravo for the way you propose things. > > Kind regards, > -- > toggg In the .phpt file, it is userland code where you can see examples of how the changes work. :-) I'm on Windows, so I don't know how you apply the .diff to your source download -- shouldn't diff work somehow? :-/ Well, I uploaded the full math.c file for 5.2 and 6 if you want to grab that to replace yours (ext/standard/math.c) and experiment with the changes. http://realplain.com/php/math.c-number_format_enhancements.tar.gz (5.2/6.0 directories with the file.) Glad you like the idea. :-) I just hope functionality like this can be added -- using my patch or not, or slightly different semantics... All I want is a no extra 0's option and not be forced to include 2 unnecessary decimal-related parameters to "get to" thousands separator when I don't want any decimals! ;-D Matt