RE: FW: [PHP-DEV] Long awaited line directive

Some feedback from Stas on the subject. I agree with him completely but wanted to get a second opinion. Honestly I think while this is somewhat useful for auto-generated files, it's not worth the risk and effort. It's a very marginal feature and very few people will use it. Supporting it in a non-intrusive way, at high quality and without making it significantly harder for debuggers and profilers to work with this is just not worth it... Andi > -----Original Message----- > From: Stanislav Malyshev [mailto:stas@zend.com] > Sent: Tuesday, August 08, 2006 7:22 AM > To: Andi Gutmans > Subject: Re: FW: [PHP-DEV] Long awaited line directive > > > I'm afraid this one would confuse debuggers. Also, if there's > any error in PHP code following line directive, it will be > reported with new filename, even if there's actually no code > causing this problem in this filename. > Also, I don't like too much the #-syntax too. And I'm not > sure it's healthy to generate code in scanner - AFAIK there > was no code generated in the scanner previously. What would > happen if someone runs tokenizer (which uses lex_scan) on > such script? Or even highlighter? > > -- > Stanislav Malyshev, Zend Products Engineer stas@zend.com > http://www.zend.com/ +972-3-6139665 ext.115 >