Re: Why is mktime(0,0,0,0,0,0) E_STRICT?
| From: | Pierre | Date: | Sun, 22 Oct 2006 22:49:25 +0000 |
| Subject: | Re: Why is mktime(0,0,0,0,0,0) E_STRICT? | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-26162@lists.php.net to get a copy of this message | ||
On 10/23/06, Pierre <pierre.php@gmail.com> wrote:
Hello,
On 10/23/06, Ilia Alshanetsky <ilia@prohost.org> wrote:
Use of mktime(0) and alike is improper use of the function, more over
generally it can be traced to an undesired code behavior.
Which is? mktime(0) is just like mktime(24); if it is not the case,
there is a bug (it is the case). But I suppose you mean mktime(0,0,0,
0,0,0);?
However and for the clarity/sanitiy of this discussion mktime(0,0,0,
0,0,0) does not raise any error, mktime(); does.
To solve the only argument in favour of this error message, Derick
should simply remove the notice and add these three little line before
the arguments parsing:
if (ZEND_NUM_ARGS() == 0) {
RETURN_LONG((long)time(NULL));
}
To be exact:
if (NUM_ARGS()==0 && !gmt) { RETURN_LONG((long)time(NULL)); }
as gmmktime uses php_mktime as well, but in GMT mode.