Re: cgi.check_shebang_line default value

I think people who want the performance can disable the check, but we should not break BC, certainly not at a patch level release. On 14-Nov-06, at 5:42 AM, Dmitry Stogov wrote:

Hi, The following patch adds new INI directive for CGI SAPI. It may enable/disable check for shebang line (#! /usr/bin/php) and as result improve performance of FastCGI. I set the default value for this directive to 1 (that means check file on each request) to not break previous behavior. However may be it is better to set default value to 0. That means break previous behavior but improve performance by default. Any suggestions? Thanks. Dmitry.

-----Original Message----- From: Dmitry Stogov [mailto:dmitry@php.net] Sent: Tuesday, November 14, 2006 1:32 PM To: php-cvs@lists.php.net Subject: [PHP-CVS] cvs: php-src /sapi/cgi cgi_main.c dmitry Tue Nov 14 10:32:11 2006 UTC Modified files:

    /php-src/sapi/cgi	cgi_main.c

Log: cgi.* and fastcgi.* directives are moved to INI subsystem. The new directive cgi.check_shebang_line can be used to ommiting checnk for "#! /usr/bin/php" line. <dmitry-20061114103211.txt>

--PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Ilia Alshanetsky