RE: [PHP-DEV] cgi.check_shebang_line default value

The patch allow save one read() and one seek() syscall for each request. On hello.php (<?php echo "Hello world!\n";?>) I got 430 req/sec without patch and 530 req/sec with patch. I think this INI directive is not a big cost for ~20% speedup. The test was done without concurency (ab -n1000 -c1). Thanks. Dmitry. > -----Original Message----- > From: Marcus Boerger [mailto:helly@php.net] > Sent: Tuesday, November 14, 2006 11:15 PM > To: Dmitry Stogov > Cc: internals@lists.php.net; Andi Gutmans; Stanislav Malyshev > Subject: Re: [PHP-DEV] cgi.check_shebang_line default value > > > Hello Dmitry, > > i thought we were avoiding new inisettings. And also having > a new INI option takes some time. So is the result really faster? > > best regards > marcus > > Tuesday, November 14, 2006, 11:42:08 AM, you wrote: > > > Hi, > > > The following patch adds new INI directive for CGI SAPI. > > It may enable/disable check for shebang line (#! > /usr/bin/php) and as > > result improve performance of FastCGI. > > > I set the default value for this directive to 1 (that means > check file > > on each request) to not break previous behavior. However > may be it is > > better to set default value to 0. That means break previous > behavior > > but improve performance by default. > > > Any suggestions? > > > Thanks. Dmitry. > > >> -----Original Message----- > >> From: Dmitry Stogov [mailto:dmitry@php.net] > >> Sent: Tuesday, November 14, 2006 1:32 PM > >> To: php-cvs@lists.php.net > >> Subject: [PHP-CVS] cvs: php-src /sapi/cgi cgi_main.c > >> > >> > >> dmitry Tue Nov 14 10:32:11 2006 UTC > >> > >> Modified files: > >> /php-src/sapi/cgi cgi_main.c > >> Log: > >> cgi.* and fastcgi.* directives are moved to INI subsystem. > >> The new directive cgi.check_shebang_line can be used to > >> ommiting checnk for "#! /usr/bin/php" line. > >> > >> > >> > > > > Best regards, > Marcus > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >