Re: [PATCH] New, optimized is_numeric_string, and other number stuff

Hi Ilia, I actually changed +2 to +4. :-) In the original message, I didn't clarify that the % improvement with numbers was obtained using arithmetic operators with one numeric string operand. And the number changes in the parser just made a few % difference in my crude way of trying to test it (repeated "<number>; ..." passed to eval()). There are also many compiler warnings now in is_numeric_unicode() on zend_cmp_unicode_and_literal(), because its parameters aren't declared const... Matt ----- Original Message ----- From: "Ilia Alshanetsky" Sent: Tuesday, December 12, 2006 > Matt, > > The zend_exceptions.c bit seems incorrect. You change +4 to +2 but > there are 4 "text" chars that need to be accounted for there. I am > going over the rest of the patch now. > > Ilia Alshanetsky