Re: [PATCH] New, optimized is_numeric_string, and other number stuff

Hi Ilia, I was kinda thinking the same thing, about having 2 RCs and such to see if any problems were found. Though I try to be very, very careful not to screw things up. ;-) Just wanted to let you know, I made a minor update to the patch since you first saw it yesterday. Realized part of the if condition for doubles wasn't needed, so "if (... && (dval || dp_or_e < 1))" became "if (... && dp_or_e < 1)", etc. Matt ----- Original Message ----- From: "Ilia Alshanetsky" Sent: Wednesday, December 13, 2006 > Given where we are in the release process i think it is a perfect > time to try this patch. If it does not work out we have at least two > RCs to revert it on, nothing would change by having us delay this > until 5.2.2, expect a slightly slower 5.2.1. I've done a detailed > review of the patch yesterday and it passes all of our existing tests > without issues, so I really see no reason to wait on it.