Re: [PATCH] 1 small optimization and 1 cleanup

I can redo the patch if you want. I do notice the braces aren't always used in if-statements (see preg_get_backref() for a few occasions). Do you want me to repost it with braces? - Ron "Andrei Zmievski" <andrei@gravitonic.com> wrote in message news:2da4c44996eb06fb90d7141e5e5ebc02@gravitonic.com... > > On Dec 13, 2006, at 10:28 AM, Ron Korving wrote: > > > + > > + if (pce) > > + { > > + if (extra) *extra = pce->extra; > > + if (preg_options) *preg_options = pce->preg_options; > > + if (compile_options) *compile_options = pce->compile_options; > > + return pce->re; > > } > > If you rewrite it, then please adhere to the code style that was used, > i.e. with explicit braces for if() statements. > > -Andrei