Re: [PATCH] 1 small optimization and 1 cleanup
| From: | Andrei Zmievski | Date: | Thu, 14 Dec 2006 17:16:53 +0000 |
| Subject: | Re: [PATCH] 1 small optimization and 1 cleanup | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-26957@lists.php.net to get a copy of this message | ||
Sure.
On Dec 14, 2006, at 9:07 AM, Ron Korving wrote:
I can redo the patch if you want. I do notice the braces aren't always used in if-statements (see preg_get_backref() for a few occasions). Do you want me to repost it with braces? - Ron "Andrei Zmievski" <andrei@gravitonic.com> wrote in message news:2da4c44996eb06fb90d7141e5e5ebc02@gravitonic.com...On Dec 13, 2006, at 10:28 AM, Ron Korving wrote:-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php+ + if (pce) + { + if (extra) *extra = pce->extra; + if (preg_options) *preg_options = pce->preg_options; + if (compile_options) *compile_options = pce->compile_options; + return pce->re; }If you rewrite it, then please adhere to the code style that was used, i.e. with explicit braces for if() statements. -Andrei