Re: cvs: php-src(PHP_5_2) / NEWS /ext/standard math.c /ext/standard/tests/strings bug39873.phpt
| From: | Ilia Alshanetsky | Date: | Fri, 22 Dec 2006 16:00:58 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_2) / NEWS /ext/standard math.c /ext/standard/tests/strings bug39873.phpt | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-27187@lists.php.net to get a copy of this message | ||
On 22-Dec-06, at 10:56 AM, Hannes Magnusson wrote:
Hi Ilia, all This fix is incorrect.. %f became locale aware internally after the recent *printf changes causing all kinds of side affects like this one.Yes and no. We should still check for both . and , for fringe cases.
We should: a) revert that change (i.e. make %f not locale aware again) (see attached patch against 5_2) or b) keep %f locale aware internally and search our code base and change %f to %FI believe b is a better option in this case, I don't think BC should be a problem in this case. But if there is a sufficient feeling that it maybe, perhaps temporary solution could be option a. Ilia Alshanetsky