Re: Re: cvs: php-src(PHP_5_2) / NEWS /ext/standard math.c /ext/standard/tests/strings bug39873.phpt

From: Date: Sun, 24 Dec 2006 12:45:31 +0000
Subject: Re: Re: cvs: php-src(PHP_5_2) / NEWS /ext/standard math.c /ext/standard/tests/strings bug39873.phpt
References: 1 2 3  Groups: php.internals 
Request: Send a blank email to internals+get-27193@lists.php.net to get a copy of this message
Hello, On 12/22/06, Ilia Alshanetsky <ilia@prohost.org> wrote:
On 22-Dec-06, at 10:56 AM, Hannes Magnusson wrote: Hi Ilia, all This fix is incorrect.. %f became locale aware internally after the recent *printf changes causing all kinds of side affects like this one. Yes and no. We should still check for both . and , for fringe cases. We should: a) revert that change (i.e. make %f not locale aware again) (see attached patch against 5_2) or b) keep %f locale aware internally and search our code base and change %f to %F I believe b is a better option in this case, I don't think BC should be a problem in this case. But if there is a sufficient feeling that it maybe, perhaps temporary solution could be option a.
Agreed, option a is the safest choice. --Pierre

« previous php.internals (#27193) next »