RE: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/standard basic_functions.c streamsfuncs.c streamsfuncs.h /ext/standard/tests/file
include_userstream_001.phpt include_userstream_002.phpt /main main.c php_globals.h php_streams.h /main/strea
| From: | Dmitry Stogov | Date: | Tue, 03 Jul 2007 15:11:17 +0000 |
| Subject: | RE: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/standard basic_functions.c streamsfuncs.c streamsfuncs.h /ext/standard/tests/file include_userstream_001.phpt include_userstream_002.phpt /main main.c php_globals.h php_streams.h /main/strea |
||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-30428@lists.php.net to get a copy of this message | ||
Btw I canot imagine extension that may use this new PG(in_user_include)
flag.
In any case the issue is not very critical and this patch may wait for 5.3.
Dmitry.
> -----Original Message-----
> From: Rasmus Lerdorf [mailto:rasmus@lerdorf.com]
> Sent: Tuesday, July 03, 2007 6:49 PM
> To: Dmitry Stogov
> Cc: 'Ilia Alshanetsky'; internals@lists.php.net; 'Stanislav Malyshev'
> Subject: Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src
> /ext/standard basic_functions.c streamsfuncs.c streamsfuncs.h
> /ext/standard/tests/file include_userstream_001.phpt
> include_userstream_002.phpt /main main.c php_globals.h
> php_streams.h /main/strea
>
>
> That is still a binary compatibility break. Binary
> compatibility isn't just backwards, but also forwards within
> a major version. eg. if I build an extension against PHP
> 5.2.3 I expect it to also work in PHP 5.2.1 and it won't in
> this case if the extension is accessing this added element.
>
> -Rasmus
>
> Dmitry Stogov wrote:
> > The size of global structure is important only during
> allocation (in
> > main.c). The offsets of all old elements of the structure are still
> > the same, because I added new element in the end.
> >
> > Dmitry.
> >
> >
> >> -----Original Message-----
> >> From: Ilia Alshanetsky [mailto:ilia@prohost.org]
> >> Sent: Tuesday, July 03, 2007 4:30 PM
> >> To: Dmitry Stogov
> >> Cc: internals@lists.php.net; Stanislav Malyshev
> >> Subject: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/standard
> >> basic_functions.c streamsfuncs.c streamsfuncs.h
> >> /ext/standard/tests/file include_userstream_001.phpt
> >> include_userstream_002.phpt /main main.c php_globals.h
> >> php_streams.h /main/streams str
> >>
> >>
> >> You are changing a global struct and it does not break BC, how does
> >> that work?
> >>
> >> Ilia
> >>
> >> --
> >> PHP Internals - PHP Runtime Development Mailing List
> >> To unsubscribe, visit: http://www.php.net/unsub.php
> >>
> >
>