Re: Re: cvs: php-src /ext/standard basic_functions.c streamsfuncs.c streamsfuncs.h /ext/standard/tests/file include_userstream_001.phpt
include_userstream_002.phpt /main main.c php_globals.h php_streams.h /main/strea

Dmitry, From your explanation it sounds like there should be any issues with putting this patch into the next 5.2.X release. On 4-Jul-07, at 2:31 AM, Dmitry Stogov wrote:

The core_globals structure is allocated/initialized in PHP itself (main.c). No one extension does it. Thanks. Dmitry.

-----Original Message----- From: sean finney [mailto:seanius@seanius.net] Sent: Tuesday, July 03, 2007 8:43 PM To: internals@lists.php.net Subject: Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/standard basic_functions.c streamsfuncs.c streamsfuncs.h /ext/standard/tests/file include_userstream_001.phpt include_userstream_002.phpt /main main.c php_globals.h php_streams.h /main/strea hi, On Tuesday 03 July 2007 17:36:07 Rasmus Lerdorf wrote:

Dmitry Stogov wrote:

Btw I canot imagine extension that may use this new PG(in_user_include) flag. In any case the issue is not

very critical

and this patch may wait for 5.3.

If there really is no reason for an extension to use this,

then I am

ok with it. I was thinking an extension might be defining a stream and setting this.

i think the problematic scenario would be an extension that was previously compiled with (and allocated/initialized an instance of) the old smaller struct, which then passed said struct to a function from the newer core version, which would expect that it was a the new (larger) struct, and attempt to access memory outside the bound of the older struct. but i'm not familiar enough with the code in question to know how this struct used and passed around between extensions and the core. sean

--PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Ilia Alshanetsky