Re: Moving SPL into the engine ?

Hi, It is still not possible to understand from this .diff what the impact on the Engine will be because the code it still saturated with copying of code from the Engine. My intentation was to review a patch that is ready to be commited. You shouldn't have to replace opcodes anymore and you shouldn't have to make copies of functions from within Zend. Also, does the array overloading stuff allow extension developers like Andrei also to hook into this? Andi At 02:06 AM 1/7/2003 +0200, Marcus Börger wrote:

Hello Andi, you asked for a spl patch against ZE2. Ok, i spent some hours to move spl-foreach hooking into the engine. Here is the diff: http://marcus-boerger.de/php/ext/ze2/ze2-spl-20030630.diff.tgz Here are modified tests: http://marcus-boerger.de/php/ext/ze2/ze2-spl-tests-20030630.tgz Here is the diff needed for sqlite: http://marcus-boerger.de/php/ext/ze2/ze2-spl-sqlite-20030630.tgz As soon as i find some more time i'll give the array stuff a go. Anyway it would be good to receive some feedback before doing it. As you can see easily, the impact on the foreah opcode handlers is even less than i thought. So i guess it is more than acceptable when compared to what we gain. Happy experimenting Best regards,

 Marcus                            mailto:helly@php.net