Re: Re: Moving SPL into the engine ?
| From: | (Marcus B�rger) | Date: | Tue, 01 Jul 2003 13:59:24 +0000 |
| Subject: | Re: Re: Moving SPL into the engine ? | ||
| References: | 1 2 3 4 5 6 7 8 9 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-3085@lists.php.net to get a copy of this message | ||
Hello Marcus,
Tuesday, July 1, 2003, 2:07:38 PM, you wrote:
MB> Hello Andi,
MB> Tuesday, July 1, 2003, 7:33:45 AM, you wrote:
AG>> Hi,
AG>> It is still not possible to understand from this .diff what the impact on
AG>> the Engine will be
MB> No? There a simply 4 additional checks/calls inside zend_execute.c. You can't
MB> see the impact of them? strange! But see down below.
AG>> because the code it still saturated with copying of code
AG>> from the Engine.
I have shuffeled some code around. Moved some zend code into a new file called
zend_execute_helpers.h and removed some spl code (hopefully this is what you
wanted to see). The whole patch becomes harder to understand now. But anyway
the impact is the same, only the codesize is same 10 bytes less and if there
are more such things the code size can now be kept smaller. Also i included the
test files into the patch.
http://marcus-boerger.de/php/ext/ze2/ze2-spl-20030701.diff.tgz
Best regards,
Marcus mailto:helly@php.net