Re: Re: run-tests.php
| From: | Marcus Boerger | Date: | Tue, 11 Sep 2007 15:19:31 +0000 |
| Subject: | Re: Re: run-tests.php | ||
| References: | 1 2 3 4 5 6 7 | Groups: | php.internals php.qa |
| Request: | Send a blank email to internals+get-32257@lists.php.net to get a copy of this message | ||
Hello Zoe,
Tuesday, September 11, 2007, 3:53:12 PM, you wrote:
> Marcus Boerger wrote:
>> Hello Zoe,
>>
>> %s = [\n]+?
> I'm not sure what this would match? I think we need something that
> matches any character but doesn't run over a line end?
> If so it would be more like [.\\n]+? - although this isn't right either
> (as in, I've tried both and they don't work :-( ).
> I'll see if I can find the right format
Damn, stupid me :-)
I meant %s = [^\n]+?
and continuing our private discussion earlier we might want to either strip
of terminating \n prior to matching or adding \n to the expression, that'd
be:
%s = [^\n]+?\n?
> However - do all OS reliably end a line with \n? (Linux is \n, Windows \r\n, Mac?). If the
> don't having a
> platform-specific run-tests.php would be a fairly bad idea
For that reason I think it would be better to strip of the line ending prior
to do the matching.
> Zoe
>> If that affects any test we have to fix those :-)
>>
>> marcus
>>
>>
>>
>> Best regards,
>> Marcus
>>
>>
>>
Best regards,
Marcus