Re: Re: run-tests.php

From:	Zoe Slattery	Date:	Wed, 12 Sep 2007 09:57:40 +0000
Subject:	Re: Re: run-tests.php
References:	1 2 3 4 5 6 7 8	Groups:	php.internals php.qa
Request:	Send a blank email to internals+get-32283@lists.php.net to get a copy of this message

Marcus Boerger wrote:

I meant %s = [^\n]+? Ah - I should have guessed that. Yes, it solves the problem, but then running make test gives an extra 7 failing tests - so I need to look at why they are failing and work out how to fix them.

and continuing our private discussion earlier we might want to either strip of terminating \n prior to matching or adding \n to the expression, that'd be: %s = [^\n]+?\n?

However - do all OS reliably end a line with \n? (Linux is \n, Windows \r\n, Mac?). If the don't having a platform-specific run-tests.php would be a fairly bad idea For that reason I think it would be better to strip of the line ending prior to do the matching. Yes - I think so.

Zoe