Re: Large file support for PHP
| From: | sean finney | Date: | Mon, 15 Oct 2007 06:27:12 +0000 |
| Subject: | Re: Large file support for PHP | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-32769@lists.php.net to get a copy of this message | ||
hi,
some non-php-dev comments in case they're helpful...
On Monday 15 October 2007 12:13:50 am Wez Furlong wrote:
> This bug has been open for a while:
> http://bugs.php.net/bug.php?id=27792
> Having run into this issue recently, here's a patch (hopefully
> attached, mail.app and list filters willing) against PHP 5.3 to
> address it.
using size_t/off_t is always good
> This patch will promote to double the file sizes that overflow
> LONG_MAX, which works transparently for my script.
> Note that this only touches the obvious functions in the core; there
> may be other extensions that need to behave similarly.
why not just use SIZE_MAX, and not have to worry about anything bigger? I
can't profess to fully understand what's going on, but it looks like the
functions are being converted from returning a long to returning either a
long or a double, and then the result is parsed as a string???
> The defines that I jam into CFLAGS are known to work in our other
> projects on Linux, Solaris, FreeBSD and OSX. The other (weirder)
> platforms might need some other adjustments to work correctly.
"getconf LFS_CFLAGS", assuming "getconf" exists...
sean
Attachment: [application/pgp-signature] This is a digitally signed message part. signature.asc
Attachment: [application/pgp-signature] This is a digitally signed message part. signature.asc