Re: Large file support for PHP

hi, On Monday 15 October 2007 07:41:11 pm Stanislav Malyshev wrote: > I didn't dive yet too deep into the patch, but shouldn't it be fixed on > stream level and not function level? I.e. there are a lot of functions > using streams (including files) - would they support bigger files too? i would suggest that anywhere where one is doing something with a size or offset and not using the posix size_t/off_t types should get such changes. and like i said, i don't see the motivation behind this extra step of returning the size in double form if it's bigger than LONG_MAX. > I also think that while using size_t is good, changing binary structures > might be rather dangerous, unless we can ensure all PHPs built on the > certain platform would use the same setting. i don't think switching from long/int -> size_t is a problem in the scope of function internal variables. the only place where you need to worry about this is in headers/structs/function declarations that are exported to the API/ABI. sean

Attachment: [application/pgp-signature] This is a digitally signed message part. signature.asc