Re: get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision
| From: | Pierre Joye | Date: | Wed, 06 Feb 2008 01:30:08 +0000 |
| Subject: | Re: get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-35220@lists.php.net to get a copy of this message | ||
Hi Rasmus,
On Feb 6, 2008 2:13 AM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:
> Daniel Brown wrote:
> > On Feb 5, 2008 3:26 PM, Daniel Brown <parasane@gmail.com> wrote:
> >> On Feb 5, 2008 3:23 PM, Pierre Joye <pierre.php@gmail.com> wrote:
> >>> Hi,
> >>>
> >>> It seems that there is voices in favor of keeping the GPC related
> >>> functions in HEAD/php6 but returning always FALSE.
> >> Personally....
> >>
> >> XX
> >
> > VOTE CHANGED
> >
> > -1
> >
> > After a quick off-list discussion with Hannes (gotta' love Gmail
> > chat), I realized that I forgot to consider backwards-compatibility.
>
> I think a lot of people miss the point of these particular functions.
> This isn't about whether to keep magic quotes or not, it is whether to
> keep the function that tells you whether magic quote mangling is
> enabled. There is a lot of code out there that checks to see if this
> feature is on, and deals with that case. Having this function that
> simply tells the code to take the other path will allow it to work.
> This is not about restoring the magic quotes feature at all.
Exactly, I thought it was clear.
As I can see it was, the votes (not that much ;) in favor of keeping
the functions argue about your example, keep the if
(get_magic_quotes_gpc...) working without changes (if (php6)...).
Cheers,
--
Pierre
http://blog.thepimp.net | http://www.libgd.org