Re: get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

On Thu, 2008-02-07 at 23:32 -0600, Larry Garfield wrote: > On Thursday 07 February 2008, Lukas Kahwe Smith wrote: > > On 07.02.2008, at 00:59, Pierre Joye wrote: > > > Hi Andi, > > > > > > On Feb 7, 2008 12:56 AM, Andi Gutmans <andi@zend.com> wrote: > > >> -1 > > >> > > >> Suggestion to enhance the suggestion: return false + emit E_STRICT > > >> message (but I am also fine with pure return false if people don't > > >> like > > >> this suggestion). > > > > > > Sounds reasonable too. It would be nice to add a deprecate notice in > > > 5.3.x as well. > > > > Yeah, note that we sort of agreed to split off an E_DEPRECATED from > > E_STRICT in PHP 5.3. > > > > regards, > > Lukas > > But in PHP 5.x, a well-written program should still be checking for magic > quotes so that it can undo the damage they cause if necessary. Not all > programs can control their environment, so checking those functions is > basically required if you want to run on a server over which you don't have > absolute control. I wouldn't say that's deprecated or a strict-violation. > > So I guess I'm -1: Restore them, always return false, and throw E_DEPRECATED. But this was about them being in PHP 6, not PHP 5.. If magic_quotes_* is gone, so should anything else even remotely related to them be gone. You have to fix your code anyway for it to work in PHP 6 (or even 5) without magic_crap.. --Jani -- Patches/Donations: http://pecl.php.net/~jani/