Re: Patch for opcode caches

On Mon, Mar 10, 2008 at 5:59 AM, Marcus Boerger <helly@php.net> wrote: > Hello Dmitry, > > please don't apply. The patch looks rather rough and untested (see below). > Also I really disagree to making the engine even more complex and adding > even more different behavior ways. That way we just introduce more errors > as we cannot test the engine in all its modes. We simply do not have the > infrastructure for that. And that means we will add even more bugs. > > Further more I am missgin a description what you really do here and why we > need to do that. Ok Opcode caches have issues but so far all attempts to do > somethign about that have been blocked. Now this one apparently has a new > option. But as far as I can tell it simply allows to change the compiler to > an opcode friendly order. If that is all what it does than we should simply > drop all the options and do it anyway without flags. > just a summary of the patch for those who don't have time to read it: ZEND_COMPILE_EXTENDED_INFO is a new way for the extended_info = 1, no logic changed except the api, only a few modules is affected, and yes it can be changed back to avoid breaking 3rd modules at source level the issues relatived to ZEND_COMPILE_DELAYED_BINDING / ZEND_COMPILE_IGNORE_INTERNAL_* can be fixed without those flags. but when we have the flag off the old implementation is used which is more optimized than the new opcode/encoder friendly implementation. correct me if i'm wrong. i'll leave the discussion to you guys, just move it fast before it's too late. thanks